Hans Leidekker : msi: Get rid of the goto in MSI_ApplicablePatchW.

Alexandre Julliard julliard at winehq.org
Tue May 25 12:06:10 CDT 2010


Module: wine
Branch: master
Commit: c815432a50f024e17427d90de942a96bde9ea63c
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=c815432a50f024e17427d90de942a96bde9ea63c

Author: Hans Leidekker <hans at codeweavers.com>
Date:   Tue May 25 12:18:32 2010 +0200

msi: Get rid of the goto in MSI_ApplicablePatchW.

---

 dlls/msi/msi.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/dlls/msi/msi.c b/dlls/msi/msi.c
index afa7005..9d8a88a 100644
--- a/dlls/msi/msi.c
+++ b/dlls/msi/msi.c
@@ -541,15 +541,14 @@ static UINT MSI_ApplicablePatchW( MSIPACKAGE *package, LPCWSTR patch )
     si = MSI_GetSummaryInformationW( patch_db->storage, 0 );
     if (!si)
     {
-        r = ERROR_FUNCTION_FAILED;
-        goto done;
+        msiobj_release( &patch_db->hdr );
+        return ERROR_FUNCTION_FAILED;
     }
 
     r = msi_check_patch_applicable( package, si );
     if (r != ERROR_SUCCESS)
         TRACE("patch not applicable\n");
 
-done:
     msiobj_release( &patch_db->hdr );
     msiobj_release( &si->hdr );
     return r;




More information about the wine-cvs mailing list