Hans Leidekker : msi: Don't crash if there is no feature parent.

Alexandre Julliard julliard at winehq.org
Wed Nov 3 11:37:09 CDT 2010


Module: wine
Branch: master
Commit: aef0aa30fd8ef50cf3915bc94a26fbfb572c1407
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=aef0aa30fd8ef50cf3915bc94a26fbfb572c1407

Author: Hans Leidekker <hans at codeweavers.com>
Date:   Wed Nov  3 15:04:07 2010 +0100

msi: Don't crash if there is no feature parent.

---

 dlls/msi/dialog.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/dlls/msi/dialog.c b/dlls/msi/dialog.c
index 1221531..a68d953 100644
--- a/dlls/msi/dialog.c
+++ b/dlls/msi/dialog.c
@@ -2258,7 +2258,11 @@ msi_seltree_add_child_features( MSIPACKAGE *package, HWND hwnd,
 
     LIST_FOR_EACH_ENTRY( feature, &package->features, MSIFEATURE, entry )
     {
-        if ( strcmpW( parent, feature->Feature_Parent ) )
+        if ( parent && feature->Feature_Parent && strcmpW( parent, feature->Feature_Parent ))
+            continue;
+        else if ( parent && !feature->Feature_Parent )
+            continue;
+        else if ( !parent && feature->Feature_Parent )
             continue;
 
         if ( !feature->Title )




More information about the wine-cvs mailing list