=?UTF-8?Q?Fr=C3=A9d=C3=A9ric=20Delanoy=20?=: crypt32: Avoid reading unitialized variables (Coverity).
Alexandre Julliard
julliard at winehq.org
Mon Dec 19 13:39:22 CST 2011
Module: wine
Branch: master
Commit: 56f035b56d5f3bd162906a723a9cd6c4bf7d0fae
URL: http://source.winehq.org/git/wine.git/?a=commit;h=56f035b56d5f3bd162906a723a9cd6c4bf7d0fae
Author: Frédéric Delanoy <frederic.delanoy at gmail.com>
Date: Fri Dec 16 13:35:29 2011 +0100
crypt32: Avoid reading unitialized variables (Coverity).
---
dlls/crypt32/encode.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/dlls/crypt32/encode.c b/dlls/crypt32/encode.c
index 05a3558..7590012 100644
--- a/dlls/crypt32/encode.c
+++ b/dlls/crypt32/encode.c
@@ -185,7 +185,7 @@ BOOL WINAPI CRYPT_AsnEncodeSequence(DWORD dwCertEncodingType,
DWORD i, dataLen = 0;
TRACE("%p, %d, %08x, %p, %p, %d\n", items, cItem, dwFlags, pEncodePara,
- pbEncoded, *pcbEncoded);
+ pbEncoded, pbEncoded ? *pcbEncoded : 0);
for (i = 0, ret = TRUE; ret && i < cItem; i++)
{
ret = items[i].encodeFunc(dwCertEncodingType, NULL,
@@ -580,7 +580,7 @@ static BOOL CRYPT_AsnEncodeCRLEntry(const CRL_ENTRY *entry,
DWORD cItem = 2;
BOOL ret;
- TRACE("%p, %p, %p\n", entry, pbEncoded, pcbEncoded);
+ TRACE("%p, %p, %d\n", entry, pbEncoded, pbEncoded ? *pcbEncoded : 0);
if (entry->cExtension)
{
@@ -736,7 +736,7 @@ static BOOL CRYPT_AsnEncodeExtension(CERT_EXTENSION *ext, BYTE *pbEncoded,
};
DWORD cItem = 1;
- TRACE("%p, %p, %d\n", ext, pbEncoded, *pcbEncoded);
+ TRACE("%p, %p, %d\n", ext, pbEncoded, pbEncoded ? *pcbEncoded : 0);
if (ext->fCritical)
{
@@ -3194,7 +3194,7 @@ BOOL WINAPI CRYPT_AsnEncodeOctets(DWORD dwCertEncodingType,
DWORD bytesNeeded, lenBytes;
TRACE("(%d, %p), %08x, %p, %p, %d\n", blob->cbData, blob->pbData,
- dwFlags, pEncodePara, pbEncoded, *pcbEncoded);
+ dwFlags, pEncodePara, pbEncoded, pbEncoded ? *pcbEncoded : 0);
CRYPT_EncodeLen(blob->cbData, NULL, &lenBytes);
bytesNeeded = 1 + lenBytes + blob->cbData;
More information about the wine-cvs
mailing list