Austin English : ole32/tests: Make sure to use return values (LLVM/Clang).
Alexandre Julliard
julliard at winehq.org
Thu Feb 10 11:42:08 CST 2011
Module: wine
Branch: master
Commit: f0ca65a287277143964fc34f5d05df05f4988d36
URL: http://source.winehq.org/git/wine.git/?a=commit;h=f0ca65a287277143964fc34f5d05df05f4988d36
Author: Austin English <austinenglish at gmail.com>
Date: Wed Feb 9 13:44:25 2011 -0800
ole32/tests: Make sure to use return values (LLVM/Clang).
---
dlls/ole32/tests/marshal.c | 17 +++++------------
1 files changed, 5 insertions(+), 12 deletions(-)
diff --git a/dlls/ole32/tests/marshal.c b/dlls/ole32/tests/marshal.c
index 25253d3..86a8f0f 100644
--- a/dlls/ole32/tests/marshal.c
+++ b/dlls/ole32/tests/marshal.c
@@ -1767,12 +1767,8 @@ static void test_proxybuffer(REFIID riid)
refs = IUnknown_Release(&pUnkOuter->IUnknown_iface);
ok(refs == 1, "Ref count of outer unknown should have been 1 instead of %d\n", refs);
- refs = IPSFactoryBuffer_Release(psfb);
- if (0)
- {
- /* not reliable on native. maybe it leaks references! */
- ok(refs == 0, "Ref-count leak of %d on IPSFactoryBuffer\n", refs);
- }
+ /* Not checking return, unreliable on native. Maybe it leaks references? */
+ IPSFactoryBuffer_Release(psfb);
refs = IUnknown_Release((IUnknown *)lpvtbl);
ok(refs == 0, "Ref-count leak of %d on IRpcProxyBuffer\n", refs);
@@ -1800,12 +1796,8 @@ static void test_stubbuffer(REFIID riid)
hr = IPSFactoryBuffer_CreateStub(psfb, riid, (IUnknown*)&Test_ClassFactory, &stub);
ok_ole_success(hr, IPSFactoryBuffer_CreateStub);
- refs = IPSFactoryBuffer_Release(psfb);
- if (0)
- {
- /* not reliable on native. maybe it leaks references */
- ok(refs == 0, "Ref-count leak of %d on IPSFactoryBuffer\n", refs);
- }
+ /* Not checking return, unreliable on native. Maybe it leaks references? */
+ IPSFactoryBuffer_Release(psfb);
ok_more_than_one_lock();
@@ -1916,6 +1908,7 @@ static LRESULT CALLBACK window_proc(HWND hwnd, UINT msg, WPARAM wparam, LPARAM l
* WM_QUIT message doesn't stop the call from succeeding */
PostMessage(hwnd, WM_QUIT, 0, 0);
hr = IClassFactory_CreateInstance(proxy, NULL, &IID_IUnknown, (void **)&object);
+ ok(hr == S_FALSE, "IClassFactory_CreateInstance returned 0x%08x, expected S_FALSE\n", hr);
IClassFactory_Release(proxy);
More information about the wine-cvs
mailing list