Michael Stefaniuc : shell32: Use FAILED instead of !SUCCEEDED.

Alexandre Julliard julliard at winehq.org
Tue Jul 19 12:42:55 CDT 2011


Module: wine
Branch: master
Commit: 5ab5042183d7461fb64ba6c4c4b8d9a2b2a4536e
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=5ab5042183d7461fb64ba6c4c4b8d9a2b2a4536e

Author: Michael Stefaniuc <mstefani at redhat.de>
Date:   Tue Jul 19 15:06:09 2011 +0200

shell32: Use FAILED instead of !SUCCEEDED.

---

 dlls/shell32/shellpath.c       |    4 ++--
 dlls/shell32/tests/brsfolder.c |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/dlls/shell32/shellpath.c b/dlls/shell32/shellpath.c
index 4b14739..4407056 100644
--- a/dlls/shell32/shellpath.c
+++ b/dlls/shell32/shellpath.c
@@ -3423,10 +3423,10 @@ static HRESULT get_known_folder_path(
     {
         /* get parent's known folder path (recursive) */
         hr = get_known_folder_registry_path(NULL, parentGuid, &parentRegistryPath);
-        if(!SUCCEEDED(hr)) return hr;
+        if(FAILED(hr)) return hr;
 
         hr = get_known_folder_path(parentGuid, parentRegistryPath, &parentPath);
-        if(!SUCCEEDED(hr)) {
+        if(FAILED(hr)) {
             HeapFree(GetProcessHeap(), 0, parentRegistryPath);
             return hr;
         }
diff --git a/dlls/shell32/tests/brsfolder.c b/dlls/shell32/tests/brsfolder.c
index 4dea03e..7b87967 100644
--- a/dlls/shell32/tests/brsfolder.c
+++ b/dlls/shell32/tests/brsfolder.c
@@ -204,7 +204,7 @@ static void test_click_make_new_folder_button(void)
         test_folder_pathW, MAX_PATH);
     hr = SHGetDesktopFolder(&test_folder_object);
     ok (SUCCEEDED(hr), "SHGetDesktopFolder failed with hr 0x%08x\n", hr);
-    if (!SUCCEEDED(hr)) {
+    if (FAILED(hr)) {
         skip("SHGetDesktopFolder failed - skipping\n");
         return;
     }
@@ -331,7 +331,7 @@ static void test_selection(void)
 
     hr = SHGetDesktopFolder(&desktop_object);
     ok (SUCCEEDED(hr), "SHGetDesktopFolder failed with hr 0x%08x\n", hr);
-    if (!SUCCEEDED(hr)) {
+    if (FAILED(hr)) {
         skip("SHGetDesktopFolder failed - skipping\n");
         return;
     }




More information about the wine-cvs mailing list