Marcus Meissner : winspool.drv: Removed a superflous NULL check (Coverity).
Alexandre Julliard
julliard at winehq.org
Wed Jun 15 13:43:04 CDT 2011
Module: wine
Branch: master
Commit: dad3342907020d821c5200189c90b8b2ed1b1fe3
URL: http://source.winehq.org/git/wine.git/?a=commit;h=dad3342907020d821c5200189c90b8b2ed1b1fe3
Author: Marcus Meissner <marcus at jet.franken.de>
Date: Wed Jun 15 17:01:07 2011 +0200
winspool.drv: Removed a superflous NULL check (Coverity).
---
dlls/winspool.drv/tests/info.c | 13 +++++--------
1 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/dlls/winspool.drv/tests/info.c b/dlls/winspool.drv/tests/info.c
index 2ef049f..9fb9070 100644
--- a/dlls/winspool.drv/tests/info.c
+++ b/dlls/winspool.drv/tests/info.c
@@ -2609,14 +2609,11 @@ static void test_GetPrinterDriver(void)
ok(filled >= calculated,"calculated %d != filled %d\n", calculated, filled);
/* Obscure test - demonstrate that Windows zero fills the buffer, even on failure */
- if (di_2->pDataFile)
- {
- ret = GetPrinterDriver(hprn, NULL, level, buf, needed - 2, &filled);
- ok(!ret, "level %d: GetPrinterDriver succeeded with less buffer than it should\n", level);
- ok(di_2->pDataFile == NULL ||
- broken(di_2->pDataFile != NULL), /* Win9x/WinMe */
- "Even on failure, GetPrinterDriver clears the buffer to zeros\n");
- }
+ ret = GetPrinterDriver(hprn, NULL, level, buf, needed - 2, &filled);
+ ok(!ret, "level %d: GetPrinterDriver succeeded with less buffer than it should\n", level);
+ ok(di_2->pDataFile == NULL ||
+ broken(di_2->pDataFile != NULL), /* Win9x/WinMe */
+ "Even on failure, GetPrinterDriver clears the buffer to zeros\n");
}
HeapFree(GetProcessHeap(), 0, buf);
More information about the wine-cvs
mailing list