Marcus Meissner : urlmon: Fixed array size check (Coverity).

Alexandre Julliard julliard at winehq.org
Mon Jun 27 17:41:22 CDT 2011


Module: wine
Branch: master
Commit: 5cf0b44d06455cd2d725a5fe75b46c28cae8919e
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=5cf0b44d06455cd2d725a5fe75b46c28cae8919e

Author: Marcus Meissner <meissner at suse.de>
Date:   Mon Jun 27 13:21:40 2011 +0200

urlmon: Fixed array size check (Coverity).

---

 dlls/urlmon/umon.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/urlmon/umon.c b/dlls/urlmon/umon.c
index d3eb44e..3e43bb8 100644
--- a/dlls/urlmon/umon.c
+++ b/dlls/urlmon/umon.c
@@ -612,7 +612,7 @@ HRESULT WINAPI CreateURLMonikerEx(IMoniker *pmkContext, LPCWSTR szURL, IMoniker
     if (!szURL || !ppmk)
         return E_INVALIDARG;
 
-    if(dwFlags > sizeof(create_flags_map)/sizeof(*create_flags_map)) {
+    if(dwFlags >= sizeof(create_flags_map)/sizeof(*create_flags_map)) {
         FIXME("Unsupported flags %x\n", dwFlags);
         return E_INVALIDARG;
     }
@@ -665,7 +665,7 @@ HRESULT WINAPI CreateURLMonikerEx2(IMoniker *pmkContext, IUri *pUri, IMoniker **
     if (!pUri || !ppmk)
         return E_INVALIDARG;
 
-    if(dwFlags > sizeof(create_flags_map)/sizeof(*create_flags_map)) {
+    if(dwFlags >= sizeof(create_flags_map)/sizeof(*create_flags_map)) {
         FIXME("Unsupported flags %x\n", dwFlags);
         return E_INVALIDARG;
     }




More information about the wine-cvs mailing list