Andrew Eikum : mmdevapi: Don't use invalid This pointer on static object.

Alexandre Julliard julliard at winehq.org
Mon Oct 3 17:21:23 CDT 2011


Module: wine
Branch: master
Commit: 6adf21173c21dfeffe85e9021978ac07885ff7f5
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=6adf21173c21dfeffe85e9021978ac07885ff7f5

Author: Andrew Eikum <aeikum at codeweavers.com>
Date:   Fri Sep 30 08:35:20 2011 -0500

mmdevapi: Don't use invalid This pointer on static object.

---

 dlls/mmdevapi/devenum.c |    6 +-----
 1 files changed, 1 insertions(+), 5 deletions(-)

diff --git a/dlls/mmdevapi/devenum.c b/dlls/mmdevapi/devenum.c
index bedd2e4..6b6cfb6 100644
--- a/dlls/mmdevapi/devenum.c
+++ b/dlls/mmdevapi/devenum.c
@@ -1236,14 +1236,10 @@ static ULONG WINAPI info_device_ps_Release(IPropertyStore *iface)
 static HRESULT WINAPI info_device_ps_GetValue(IPropertyStore *iface,
         REFPROPERTYKEY key, PROPVARIANT *pv)
 {
-    MMDevPropStore *This = impl_from_IPropertyStore(iface);
-    TRACE("(%p)->(\"%s,%u\", %p)\n", This, debugstr_guid(&key->fmtid), key ? key->pid : 0, pv);
+    TRACE("(static)->(\"%s,%u\", %p)\n", debugstr_guid(&key->fmtid), key ? key->pid : 0, pv);
 
     if (!key || !pv)
         return E_POINTER;
-    if (This->access != STGM_READ
-        && This->access != STGM_READWRITE)
-        return STG_E_ACCESSDENIED;
 
     if (IsEqualPropertyKey(*key, DEVPKEY_Device_Driver))
     {




More information about the wine-cvs mailing list