Nikolay Sivov : msxml3: Use helper to set properties.

Alexandre Julliard julliard at winehq.org
Thu Oct 6 17:24:30 CDT 2011


Module: wine
Branch: master
Commit: 5931af0283c7426f2d19f7d1ae5f73cdef6e57ea
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=5931af0283c7426f2d19f7d1ae5f73cdef6e57ea

Author: Nikolay Sivov <nsivov at codeweavers.com>
Date:   Thu Oct  6 10:22:00 2011 -0500

msxml3: Use helper to set properties.

---

 dlls/msxml3/mxwriter.c |   32 ++++++++++++--------------------
 1 files changed, 12 insertions(+), 20 deletions(-)

diff --git a/dlls/msxml3/mxwriter.c b/dlls/msxml3/mxwriter.c
index a863336..0214d80 100644
--- a/dlls/msxml3/mxwriter.c
+++ b/dlls/msxml3/mxwriter.c
@@ -179,6 +179,13 @@ static inline void reset_output_buffer(mxwriter *This)
     This->dest_written = 0;
 }
 
+static HRESULT writer_set_property(mxwriter *writer, MXWRITER_PROPS property, VARIANT_BOOL value)
+{
+    writer->props[property] = value;
+    writer->prop_changed = TRUE;
+    return S_OK;
+}
+
 static inline mxwriter *impl_from_IMXWriter(IMXWriter *iface)
 {
     return CONTAINING_RECORD(iface, mxwriter, IMXWriter_iface);
@@ -454,10 +461,7 @@ static HRESULT WINAPI mxwriter_put_byteOrderMark(IMXWriter *iface, VARIANT_BOOL
     mxwriter *This = impl_from_IMXWriter( iface );
 
     TRACE("(%p)->(%d)\n", This, value);
-    This->props[MXWriter_BOM] = value;
-    This->prop_changed = TRUE;
-
-    return S_OK;
+    return writer_set_property(This, MXWriter_BOM, value);
 }
 
 static HRESULT WINAPI mxwriter_get_byteOrderMark(IMXWriter *iface, VARIANT_BOOL *value)
@@ -478,10 +482,7 @@ static HRESULT WINAPI mxwriter_put_indent(IMXWriter *iface, VARIANT_BOOL value)
     mxwriter *This = impl_from_IMXWriter( iface );
 
     TRACE("(%p)->(%d)\n", This, value);
-    This->props[MXWriter_Indent] = value;
-    This->prop_changed = TRUE;
-
-    return S_OK;
+    return writer_set_property(This, MXWriter_Indent, value);
 }
 
 static HRESULT WINAPI mxwriter_get_indent(IMXWriter *iface, VARIANT_BOOL *value)
@@ -502,10 +503,7 @@ static HRESULT WINAPI mxwriter_put_standalone(IMXWriter *iface, VARIANT_BOOL val
     mxwriter *This = impl_from_IMXWriter( iface );
 
     TRACE("(%p)->(%d)\n", This, value);
-    This->props[MXWriter_Standalone] = value;
-    This->prop_changed = TRUE;
-
-    return S_OK;
+    return writer_set_property(This, MXWriter_Standalone, value);
 }
 
 static HRESULT WINAPI mxwriter_get_standalone(IMXWriter *iface, VARIANT_BOOL *value)
@@ -526,10 +524,7 @@ static HRESULT WINAPI mxwriter_put_omitXMLDeclaration(IMXWriter *iface, VARIANT_
     mxwriter *This = impl_from_IMXWriter( iface );
 
     TRACE("(%p)->(%d)\n", This, value);
-    This->props[MXWriter_OmitXmlDecl] = value;
-    This->prop_changed = TRUE;
-
-    return S_OK;
+    return writer_set_property(This, MXWriter_OmitXmlDecl, value);
 }
 
 static HRESULT WINAPI mxwriter_get_omitXMLDeclaration(IMXWriter *iface, VARIANT_BOOL *value)
@@ -575,10 +570,7 @@ static HRESULT WINAPI mxwriter_put_disableOutputEscaping(IMXWriter *iface, VARIA
     mxwriter *This = impl_from_IMXWriter( iface );
 
     TRACE("(%p)->(%d)\n", This, value);
-    This->props[MXWriter_DisableEscaping] = value;
-    This->prop_changed = TRUE;
-
-    return S_OK;
+    return writer_set_property(This, MXWriter_DisableEscaping, value);
 }
 
 static HRESULT WINAPI mxwriter_get_disableOutputEscaping(IMXWriter *iface, VARIANT_BOOL *value)




More information about the wine-cvs mailing list