Michael Stefaniuc : msi: Remove a redundant NULL check before free (Smatch) .

Alexandre Julliard julliard at winehq.org
Tue Oct 11 14:03:38 CDT 2011


Module: wine
Branch: master
Commit: 78ebd8f7cf5fc3bbf00cf0770ef85b81fb4d9bca
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=78ebd8f7cf5fc3bbf00cf0770ef85b81fb4d9bca

Author: Michael Stefaniuc <mstefani at redhat.de>
Date:   Tue Oct 11 00:03:35 2011 +0200

msi: Remove a redundant NULL check before free (Smatch).

---

 dlls/msi/where.c |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/dlls/msi/where.c b/dlls/msi/where.c
index 2d9241f..8272301 100644
--- a/dlls/msi/where.c
+++ b/dlls/msi/where.c
@@ -919,11 +919,8 @@ static UINT WHERE_delete( struct tagMSIVIEW *view )
 
     free_reorder(wv);
 
-    if (wv->order_info)
-    {
-        msi_free(wv->order_info);
-        wv->order_info = NULL;
-    }
+    msi_free(wv->order_info);
+    wv->order_info = NULL;
 
     msiobj_release( &wv->db->hdr );
     msi_free( wv );




More information about the wine-cvs mailing list