Marcus Meissner : Revert "msi: Check for return value of GetUserName ( Coverity).".

Alexandre Julliard julliard at winehq.org
Thu Sep 8 14:52:11 CDT 2011


Module: wine
Branch: master
Commit: 6d1ec3517dfe6ee315bfda8bdccbfec00854738a
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=6d1ec3517dfe6ee315bfda8bdccbfec00854738a

Author: Marcus Meissner <marcus at jet.franken.de>
Date:   Thu Sep  8 07:51:16 2011 +0200

Revert "msi: Check for return value of GetUserName (Coverity).".

This reverts commit ac0a7b644fa464fa640e06a6e26b2191b5a29a92.
GetUserName is supposed to return 0 here, as size is 0.

---

 dlls/msi/package.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/dlls/msi/package.c b/dlls/msi/package.c
index bec7627..1025607 100644
--- a/dlls/msi/package.c
+++ b/dlls/msi/package.c
@@ -501,8 +501,7 @@ static UINT set_user_sid_prop( MSIPACKAGE *package )
     UINT r = ERROR_FUNCTION_FAILED;
 
     size = 0;
-    if (!GetUserNameW( NULL, &size ))
-	return r;
+    GetUserNameW( NULL, &size );
 
     user_name = msi_alloc( (size + 1) * sizeof(WCHAR) );
     if (!user_name)




More information about the wine-cvs mailing list