=?UTF-8?Q?J=C3=B6rg=20H=C3=B6hle=20?=: winealsa: Recommend Pulse users to upgrade to handle_underrun.

Alexandre Julliard julliard at winehq.org
Thu Sep 8 14:52:13 CDT 2011


Module: wine
Branch: master
Commit: 9c75a6aae5518357df464db7c352b27010dafff4
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=9c75a6aae5518357df464db7c352b27010dafff4

Author: Jörg Höhle <hoehle at users.sourceforge.net>
Date:   Tue Aug 23 23:07:54 2011 +0200

winealsa: Recommend Pulse users to upgrade to handle_underrun.

---

 dlls/winealsa.drv/mmdevdrv.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/dlls/winealsa.drv/mmdevdrv.c b/dlls/winealsa.drv/mmdevdrv.c
index 836d444..916c247 100644
--- a/dlls/winealsa.drv/mmdevdrv.c
+++ b/dlls/winealsa.drv/mmdevdrv.c
@@ -47,6 +47,7 @@
 #include <alsa/asoundlib.h>
 
 WINE_DEFAULT_DEBUG_CHANNEL(alsa);
+WINE_DECLARE_DEBUG_CHANNEL(winediag);
 
 #define NULL_PTR_ERR MAKE_HRESULT(SEVERITY_ERROR, FACILITY_WIN32, RPC_X_NULL_REF_POINTER)
 
@@ -540,8 +541,11 @@ HRESULT WINAPI AUDDRV_GetAudioEndpoint(const char *key, IMMDevice *dev,
         TRACE("Opening PCM device \"%s\" with handle_underrun: %d\n", key, err);
         snd_config_delete(lconf);
         /* Pulse <= 2010 returns EINVAL, it does not know handle_underrun. */
-        if(err == -EINVAL)
+        if(err == -EINVAL){
+            ERR_(winediag)("PulseAudio \"%s\" %d without handle_underrun. Audio may hang."
+                           " Please upgrade to alsa_plugins >= 1.0.24\n", key, err);
             handle_underrun = 0;
+        }
     }else
         err = -EINVAL;
     if(err == -EINVAL){




More information about the wine-cvs mailing list