Marcus Meissner : qcap: Fixed another use-after free (Coverity).

Alexandre Julliard julliard at winehq.org
Mon Aug 20 14:16:17 CDT 2012


Module: wine
Branch: master
Commit: 985d2ba18ed736423fb161985faf45adcc505b62
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=985d2ba18ed736423fb161985faf45adcc505b62

Author: Marcus Meissner <marcus at jet.franken.de>
Date:   Fri Aug 17 23:07:11 2012 +0200

qcap: Fixed another use-after free (Coverity).

---

 dlls/qcap/vfwcapture.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/dlls/qcap/vfwcapture.c b/dlls/qcap/vfwcapture.c
index 7be59cc..227a671 100644
--- a/dlls/qcap/vfwcapture.c
+++ b/dlls/qcap/vfwcapture.c
@@ -793,11 +793,11 @@ VfwPin_EnumMediaTypes(IPin * iface, IEnumMediaTypes ** ppEnum)
 
     VfwPinImpl *This = (VfwPinImpl *)iface;
     hr = qcap_driver_get_format(This->driver_info, &pmt);
-    if (SUCCEEDED(hr))
+    if (SUCCEEDED(hr)) {
         hr = BasePinImpl_EnumMediaTypes(iface, ppEnum);
+        DeleteMediaType(pmt);
+    }
     TRACE("%p -- %x\n", This, hr);
-    DeleteMediaType(pmt);
-
     return hr;
 }
 




More information about the wine-cvs mailing list