Francois Gouget : testbot/lib: Add an EnumPropertyDescriptor class for enum properties.

Alexandre Julliard julliard at winehq.org
Fri Aug 31 12:51:18 CDT 2012


Module: tools
Branch: master
Commit: 0a1c694864960d69355fb98b7a755ce0cf5de44f
URL:    http://source.winehq.org/git/tools.git/?a=commit;h=0a1c694864960d69355fb98b7a755ce0cf5de44f

Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Fri Aug 31 17:18:07 2012 +0200

testbot/lib: Add an EnumPropertyDescriptor class for enum properties.

This lets us display the right options in the web interface, thus
avoiding the risk of incorrect entry. This also lets us validate the
values before trying to store them in the database. In particular this
avoids silently dropping an incorrect 'Type' value when modifying a
VM.

---

 testbot/lib/ObjectModel/CGI/FormPage.pm           |   18 +++++
 testbot/lib/ObjectModel/CGI/ItemPage.pm           |    4 +-
 testbot/lib/ObjectModel/EnumPropertyDescriptor.pm |   86 +++++++++++++++++++++
 testbot/lib/ObjectModel/Item.pm                   |    4 +-
 testbot/lib/WineTestBot/Jobs.pm                   |    4 +-
 testbot/lib/WineTestBot/Steps.pm                  |    8 +-
 testbot/lib/WineTestBot/Tasks.pm                  |    4 +-
 testbot/lib/WineTestBot/VMs.pm                    |    8 +-
 testbot/web/admin/VMDetails.pl                    |   26 +------
 9 files changed, 127 insertions(+), 35 deletions(-)

Diff:   http://source.winehq.org/git/tools.git/?a=commitdiff;h=0a1c694864960d69355fb98b7a755ce0cf5de44f



More information about the wine-cvs mailing list