Francois Gouget : testbot/TestAgent: Remove some unneeded checks for a broken connection.

Alexandre Julliard julliard at winehq.org
Thu Dec 6 16:24:24 CST 2012


Module: tools
Branch: master
Commit: 2ff8c9c40724bdd5771ab92d197c2438639c01c3
URL:    http://source.winehq.org/git/tools.git/?a=commit;h=2ff8c9c40724bdd5771ab92d197c2438639c01c3

Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Thu Dec  6 21:01:13 2012 +0100

testbot/TestAgent: Remove some unneeded checks for a broken connection.

These checks are redundant with the first recv_xxx() or send_xxx() call these functions make (only send_file() is a slightly special case).

---

 testbot/src/testagentd/testagentd.c |   12 ------------
 1 files changed, 0 insertions(+), 12 deletions(-)

diff --git a/testbot/src/testagentd/testagentd.c b/testbot/src/testagentd/testagentd.c
index 6d4589e..fc3a840 100644
--- a/testbot/src/testagentd/testagentd.c
+++ b/testbot/src/testagentd/testagentd.c
@@ -215,9 +215,6 @@ static int recv_raw_data(SOCKET client, void* data, uint64_t size)
 
 static int recv_raw_uint32(SOCKET client, uint32_t *u32)
 {
-    if (broken)
-        return 0;
-
     if (!recv_raw_data(client, u32, sizeof(*u32)))
         return 0;
     *u32 = ntohl(*u32);
@@ -228,9 +225,6 @@ static int recv_raw_uint64(SOCKET client, uint64_t *u64)
 {
     uint32_t high, low;
 
-    if (broken)
-        return 0;
-
     if (!recv_raw_uint32(client, &high) || !recv_raw_uint32(client, &low))
         return 0;
     *u64 = ((uint64_t)high) << 32 | low;
@@ -244,9 +238,6 @@ static int recv_raw_uint64(SOCKET client, uint64_t *u64)
 
 static int recv_entry_header(SOCKET client, char *type, uint64_t *size)
 {
-    if (broken)
-        return 0;
-
     return recv_raw_data(client, type, sizeof(*type)) &&
            recv_raw_uint64(client, size);
 }
@@ -259,9 +250,6 @@ static int expect_entry_header(SOCKET client, char type, uint64_t *size)
     uint64_t hsize;
     int success;
 
-    if (broken)
-        return 0;
-
     if (!recv_entry_header(client, &htype, &hsize))
         return 0;
 




More information about the wine-cvs mailing list