Michael Stefaniuc : localui: Avoid sizeof on structs with a varlength array .

Alexandre Julliard julliard at winehq.org
Tue Dec 11 14:41:15 CST 2012


Module: wine
Branch: master
Commit: f417dc1efbd227c6c88ab57143c2f8363d62c0b8
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=f417dc1efbd227c6c88ab57143c2f8363d62c0b8

Author: Michael Stefaniuc <mstefani at redhat.de>
Date:   Tue Dec 11 13:35:40 2012 +0100

localui: Avoid sizeof on structs with a varlength array.

---

 dlls/localui/localui.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dlls/localui/localui.c b/dlls/localui/localui.c
index b9e4c4e..382e2db 100644
--- a/dlls/localui/localui.c
+++ b/dlls/localui/localui.c
@@ -122,7 +122,7 @@ static BOOL dlg_configure_com(HANDLE hXcv, HWND hWnd, PCWSTR pPortName)
         shortname[len-1] = '\0';
 
         /* get current settings */
-        len = sizeof(cfg);
+        len = FIELD_OFFSET(COMMCONFIG, wcProviderData[1]);
         status = ERROR_SUCCESS;
         res = XcvDataW( hXcv, cmd_GetDefaultCommConfigW,
                         (PBYTE) shortname,




More information about the wine-cvs mailing list