Hans Leidekker : msi: Use the return value of IXMLDOMNode_get_text (clang).
Alexandre Julliard
julliard at winehq.org
Mon Feb 6 15:17:59 CST 2012
Module: wine
Branch: master
Commit: 98c621c1bf1a4af545802f2c2a0fcb955cbf38cb
URL: http://source.winehq.org/git/wine.git/?a=commit;h=98c621c1bf1a4af545802f2c2a0fcb955cbf38cb
Author: Hans Leidekker <hans at codeweavers.com>
Date: Mon Feb 6 13:05:14 2012 +0100
msi: Use the return value of IXMLDOMNode_get_text (clang).
---
dlls/msi/msi.c | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/dlls/msi/msi.c b/dlls/msi/msi.c
index f34bfc9..4022b3a 100644
--- a/dlls/msi/msi.c
+++ b/dlls/msi/msi.c
@@ -613,8 +613,11 @@ static UINT MSI_ApplicablePatchXML( MSIPACKAGE *package, IXMLDOMDocument *desc )
{
hr = IXMLDOMNode_get_text( node, &s );
IXMLDOMNode_Release( node );
- if (!strcmpW( s, product_code )) r = ERROR_SUCCESS;
- SysFreeString(s);
+ if (hr == S_OK)
+ {
+ if (!strcmpW( s, product_code )) r = ERROR_SUCCESS;
+ SysFreeString( s );
+ }
}
IXMLDOMNodeList_Release( list );
More information about the wine-cvs
mailing list