=?UTF-8?Q?Fr=C3=A9d=C3=A9ric=20Delanoy=20?=: cmd: Avoid unreachable code ( Coverity).

Alexandre Julliard julliard at winehq.org
Tue Jan 3 12:52:55 CST 2012


Module: wine
Branch: master
Commit: 0b358703ca54fa2fbb0769ac20cb46e5c39bf2ea
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=0b358703ca54fa2fbb0769ac20cb46e5c39bf2ea

Author: Frédéric Delanoy <frederic.delanoy at gmail.com>
Date:   Tue Jan  3 18:29:40 2012 +0100

cmd: Avoid unreachable code (Coverity).

---

 programs/cmd/wcmdmain.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/programs/cmd/wcmdmain.c b/programs/cmd/wcmdmain.c
index 67a524d..6330ef6 100644
--- a/programs/cmd/wcmdmain.c
+++ b/programs/cmd/wcmdmain.c
@@ -725,8 +725,6 @@ static WCHAR *WCMD_expand_envvar(WCHAR *start,
         WCMD_strsubstW(start, endOfVar + 1, startCopy, substrlength);
       }
 
-      return start;
-
     /* search and replace manipulation */
     } else {
       WCHAR *equalspos = strstrW(colonpos, equalW);
@@ -786,9 +784,8 @@ static WCHAR *WCMD_expand_envvar(WCHAR *start,
       HeapFree(GetProcessHeap(), 0, s);
       HeapFree(GetProcessHeap(), 0, searchIn);
       HeapFree(GetProcessHeap(), 0, searchFor);
-      return start;
     }
-    return start+1;
+    return start;
 }
 
 /*****************************************************************************




More information about the wine-cvs mailing list