Nikolay Sivov : msxml3: Properly store SystemID and PublicID (Coverity).

Alexandre Julliard julliard at winehq.org
Wed Nov 28 14:14:05 CST 2012


Module: wine
Branch: master
Commit: 818917a09e71d5459ffe05d6ba067a9302d24b70
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=818917a09e71d5459ffe05d6ba067a9302d24b70

Author: Nikolay Sivov <nsivov at codeweavers.com>
Date:   Wed Nov 28 12:45:12 2012 -0500

msxml3: Properly store SystemID and PublicID (Coverity).

---

 dlls/msxml3/saxreader.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/dlls/msxml3/saxreader.c b/dlls/msxml3/saxreader.c
index 877493d..3b167b7 100644
--- a/dlls/msxml3/saxreader.c
+++ b/dlls/msxml3/saxreader.c
@@ -294,8 +294,8 @@ typedef struct
     saxreader *saxreader;
     HRESULT ret;
     xmlParserCtxtPtr pParserCtxt;
-    WCHAR *publicId;
-    WCHAR *systemId;
+    BSTR publicId;
+    BSTR systemId;
     int line;
     int column;
     BOOL vbInterface;
@@ -2132,7 +2132,7 @@ static HRESULT WINAPI isaxlocator_getPublicId(
 
     publicId = bstr_from_xmlChar(xmlSAX2GetPublicId(This->pParserCtxt));
     if(SysStringLen(publicId))
-        This->publicId = (WCHAR*)&publicId;
+        This->publicId = publicId;
     else
     {
         SysFreeString(publicId);
@@ -2154,7 +2154,7 @@ static HRESULT WINAPI isaxlocator_getSystemId(
 
     systemId = bstr_from_xmlChar(xmlSAX2GetSystemId(This->pParserCtxt));
     if(SysStringLen(systemId))
-        This->systemId = (WCHAR*)&systemId;
+        This->systemId = systemId;
     else
     {
         SysFreeString(systemId);




More information about the wine-cvs mailing list