Marcus Meissner : dinput: Added some missing free/close in disabled case ( Coverity).

Alexandre Julliard julliard at winehq.org
Mon Sep 3 13:19:11 CDT 2012


Module: wine
Branch: master
Commit: e10a658c0cde12f7713d9e4c13e1a35b5108202d
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=e10a658c0cde12f7713d9e4c13e1a35b5108202d

Author: Marcus Meissner <meissner at suse.de>
Date:   Sun Sep  2 15:01:27 2012 +0200

dinput: Added some missing free/close in disabled case (Coverity).

---

 dlls/dinput/joystick_linuxinput.c |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/dlls/dinput/joystick_linuxinput.c b/dlls/dinput/joystick_linuxinput.c
index 341e169..466b6bf 100644
--- a/dlls/dinput/joystick_linuxinput.c
+++ b/dlls/dinput/joystick_linuxinput.c
@@ -251,7 +251,13 @@ static void find_joydevs(void)
         else
             joydev.name = joydev.device;
 
-        if (device_disabled_registry(joydev.name)) continue;
+        if (device_disabled_registry(joydev.name)) {
+            close(fd);
+            HeapFree(GetProcessHeap(), 0, joydev.name);
+            if (joydev.name != joydev.device)
+                HeapFree(GetProcessHeap(), 0, joydev.device);
+            continue;
+        }
 
         joydev.guid = DInput_Wine_Joystick_Base_GUID;
         joydev.guid.Data3 += have_joydevs;




More information about the wine-cvs mailing list