Marcus Meissner : msi: Move free after last usage (Coverity).
Alexandre Julliard
julliard at winehq.org
Thu Sep 6 13:37:23 CDT 2012
Module: wine
Branch: master
Commit: b9550ad35239db39e2d4cf3411a381319cf652c5
URL: http://source.winehq.org/git/wine.git/?a=commit;h=b9550ad35239db39e2d4cf3411a381319cf652c5
Author: Marcus Meissner <meissner at suse.de>
Date: Thu Sep 6 15:19:48 2012 +0200
msi: Move free after last usage (Coverity).
---
dlls/msi/table.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/dlls/msi/table.c b/dlls/msi/table.c
index dd25fbb..93b0268 100644
--- a/dlls/msi/table.c
+++ b/dlls/msi/table.c
@@ -2328,12 +2328,15 @@ static MSIRECORD *msi_get_transform_record( const MSITABLEVIEW *tv, const string
r = IStorage_OpenStream( stg, encname, NULL,
STGM_READ | STGM_SHARE_EXCLUSIVE, 0, &stm );
- msi_free( encname );
if ( r != ERROR_SUCCESS )
+ {
+ msi_free( encname );
return NULL;
+ }
MSI_RecordSetStream( rec, i+1, stm );
TRACE(" field %d [%s]\n", i+1, debugstr_w(encname));
+ msi_free( encname );
}
else if( columns[i].type & MSITYPE_STRING )
{
More information about the wine-cvs
mailing list