Marcus Meissner : advpack: Avoid using sessions uninitialized (Coverity).

Alexandre Julliard julliard at winehq.org
Tue Jan 8 13:58:41 CST 2013


Module: wine
Branch: master
Commit: a6e4c094d0002e35f9a70902565c4896d2a6ab83
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=a6e4c094d0002e35f9a70902565c4896d2a6ab83

Author: Marcus Meissner <meissner at suse.de>
Date:   Mon Jan  7 22:17:36 2013 +0100

advpack: Avoid using sessions uninitialized (Coverity).

---

 dlls/advpack/files.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/dlls/advpack/files.c b/dlls/advpack/files.c
index c34f6d5..a1d52f8 100644
--- a/dlls/advpack/files.c
+++ b/dlls/advpack/files.c
@@ -708,6 +708,8 @@ HRESULT WINAPI ExtractFilesA(LPCSTR CabName, LPCSTR ExpandDir, DWORD Flags,
     if (!hCabinet)
         return E_FAIL;
 
+    ZeroMemory(&session, sizeof(SESSION));
+
     pExtract = (void *)GetProcAddress(hCabinet, "Extract");
     if (!pExtract)
     {
@@ -715,7 +717,6 @@ HRESULT WINAPI ExtractFilesA(LPCSTR CabName, LPCSTR ExpandDir, DWORD Flags,
         goto done;
     }
 
-    ZeroMemory(&session, sizeof(SESSION));
     lstrcpyA(session.Destination, ExpandDir);
 
     if (FileList)




More information about the wine-cvs mailing list