Marcus Meissner : comctl32: Avoid leak of hShell32 (Coverity).

Alexandre Julliard julliard at winehq.org
Wed Jan 9 13:30:37 CST 2013


Module: wine
Branch: master
Commit: d8d83d2eb3401db0d5be0a188cba3e145e95fb6e
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=d8d83d2eb3401db0d5be0a188cba3e145e95fb6e

Author: Marcus Meissner <meissner at suse.de>
Date:   Wed Jan  9 02:42:13 2013 +0100

comctl32: Avoid leak of hShell32 (Coverity).

---

 dlls/comctl32/tests/imagelist.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/dlls/comctl32/tests/imagelist.c b/dlls/comctl32/tests/imagelist.c
index f2da3c2..19d2437 100644
--- a/dlls/comctl32/tests/imagelist.c
+++ b/dlls/comctl32/tests/imagelist.c
@@ -1160,6 +1160,7 @@ static void test_shell_imagelist(void)
     if (!pSHGetImageList)
     {
         win_skip("SHGetImageList not available, skipping test\n");
+        FreeLibrary(hShell32);
         return;
     }
 
@@ -1168,8 +1169,10 @@ static void test_shell_imagelist(void)
 
     ok(SUCCEEDED(hr), "SHGetImageList failed, hr=%x\n", hr);
 
-    if (hr != S_OK)
+    if (hr != S_OK) {
+        FreeLibrary(hShell32);
         return;
+    }
 
     IImageList_GetImageCount(iml, &out);
     ok(out > 0, "IImageList_GetImageCount returned out <= 0\n");




More information about the wine-cvs mailing list