Marcus Meissner : user32/tests: Remove side effects from assert()s.

Alexandre Julliard julliard at winehq.org
Mon Jun 10 15:12:44 CDT 2013


Module: wine
Branch: master
Commit: b853ddc40b342e02d7cab7ade2c2c7e544b9935d
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=b853ddc40b342e02d7cab7ade2c2c7e544b9935d

Author: Marcus Meissner <marcus at jet.franken.de>
Date:   Sun Jun  9 22:39:54 2013 +0200

user32/tests: Remove side effects from assert()s.

---

 dlls/user32/tests/win.c |   12 ++++++++----
 1 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/dlls/user32/tests/win.c b/dlls/user32/tests/win.c
index 2d9faaa..abd7f8d 100644
--- a/dlls/user32/tests/win.c
+++ b/dlls/user32/tests/win.c
@@ -1523,10 +1523,14 @@ static void test_MDI_child_stack(HWND mdi_client)
     cs.style   = 0;
     cs.lParam  = (LPARAM)mdi_lParam_test_message;
 
-    assert(child_1 = (HWND)SendMessageA(mdi_client, WM_MDICREATE, 0, (LPARAM)&cs));
-    assert(child_2 = (HWND)SendMessageA(mdi_client, WM_MDICREATE, 0, (LPARAM)&cs));
-    assert(child_3 = (HWND)SendMessageA(mdi_client, WM_MDICREATE, 0, (LPARAM)&cs));
-    assert(child_4 = (HWND)SendMessageA(mdi_client, WM_MDICREATE, 0, (LPARAM)&cs));
+    child_1 = (HWND)SendMessageA(mdi_client, WM_MDICREATE, 0, (LPARAM)&cs);
+    ok(child_1 != 0, "expected child_1 to be non NULL");
+    child_2 = (HWND)SendMessageA(mdi_client, WM_MDICREATE, 0, (LPARAM)&cs);
+    ok(child_2 != 0, "expected child_2 to be non NULL");
+    child_3 = (HWND)SendMessageA(mdi_client, WM_MDICREATE, 0, (LPARAM)&cs);
+    ok(child_3 != 0, "expected child_3 to be non NULL");
+    child_4 = (HWND)SendMessageA(mdi_client, WM_MDICREATE, 0, (LPARAM)&cs);
+    ok(child_4 != 0, "expected child_4 to be non NULL");
 
     stack[0] = (HWND)SendMessageA(mdi_client, WM_MDIGETACTIVE, 0, 0);
     stack[1] = GetWindow(stack[0], GW_HWNDNEXT);




More information about the wine-cvs mailing list