Francois Gouget : testbot: When restarting a task, reset all the fields related to its previous run.
Alexandre Julliard
julliard at winehq.org
Tue Mar 26 11:52:22 CDT 2013
Module: tools
Branch: master
Commit: 0160d815ceca3746d5464741eefbd164543bb7fd
URL: http://source.winehq.org/git/tools.git/?a=commit;h=0160d815ceca3746d5464741eefbd164543bb7fd
Author: Francois Gouget <fgouget at codeweavers.com>
Date: Tue Mar 26 10:55:12 2013 +0100
testbot: When restarting a task, reset all the fields related to its previous run.
Some fields like the start and stop time would still be displayed and
could be confusing. The 'TestFailures' field could even not get reset
if the task then is canceled or fails to run and thus report incorrect
results.
---
testbot/lib/WineTestBot/Jobs.pm | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/testbot/lib/WineTestBot/Jobs.pm b/testbot/lib/WineTestBot/Jobs.pm
index cd6c427..c73dea1 100644
--- a/testbot/lib/WineTestBot/Jobs.pm
+++ b/testbot/lib/WineTestBot/Jobs.pm
@@ -231,6 +231,10 @@ sub Restart
system("rm", "-rf", "$JobDir/" . $Step->No . "/" . $Task->No);
}
$Task->Status("queued");
+ $Task->ChildPid(undef);
+ $Task->Started(undef);
+ $Task->Ended(undef);
+ $Task->TestFailures(undef);
}
# Subsequent steps only contain files generated by the previous steps
system("rm", "-rf", "$JobDir/" . $Step->No) if (!$FirstStep);
More information about the wine-cvs
mailing list