Marcus Meissner : oledb32: Avoid leak in error path on safearray conversion (Coverity).

Alexandre Julliard julliard at winehq.org
Mon May 27 13:46:54 CDT 2013


Module: wine
Branch: master
Commit: 36fee7c2e5e9339256d5b1e7cad632af4863690c
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=36fee7c2e5e9339256d5b1e7cad632af4863690c

Author: Marcus Meissner <marcus at jet.franken.de>
Date:   Sat May 25 09:25:19 2013 +0200

oledb32: Avoid leak in error path on safearray conversion (Coverity).

---

 dlls/oledb32/convert.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/dlls/oledb32/convert.c b/dlls/oledb32/convert.c
index 0961464..a2fd0cb 100644
--- a/dlls/oledb32/convert.c
+++ b/dlls/oledb32/convert.c
@@ -957,8 +957,10 @@ static HRESULT WINAPI convert_DataConvert(IDataConvert* iface,
             for(i =0; i < size; i++,p++)
             {
                 hr = SafeArrayPutElement(psa, &i, &p);
-                if(FAILED(hr))
+                if(FAILED(hr)) {
+                   SafeArrayDestroy (psa);
                    return hr;
+                }
             }
 
             V_VT(v) = VT_ARRAY|VT_UI1;




More information about the wine-cvs mailing list