Bruno Jesus : ws2_32: Fix some parameters checking in AcceptEx.
Alexandre Julliard
julliard at winehq.org
Tue Sep 24 03:22:00 CDT 2013
Module: wine
Branch: master
Commit: d0009573eea2e5bad3ce810ddfb22fef99fe969c
URL: http://source.winehq.org/git/wine.git/?a=commit;h=d0009573eea2e5bad3ce810ddfb22fef99fe969c
Author: Bruno Jesus <00cpxxx at gmail.com>
Date: Sat Sep 21 16:45:20 2013 -0300
ws2_32: Fix some parameters checking in AcceptEx.
---
dlls/ws2_32/socket.c | 7 +++++++
dlls/ws2_32/tests/sock.c | 18 ++++++++++++++++--
2 files changed, 23 insertions(+), 2 deletions(-)
diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c
index fac090d..c606659 100644
--- a/dlls/ws2_32/socket.c
+++ b/dlls/ws2_32/socket.c
@@ -2319,6 +2319,13 @@ static BOOL WINAPI WS2_AcceptEx(SOCKET listener, SOCKET acceptor, PVOID dest, DW
return FALSE;
}
+ if ((local_addr_len < sizeof(struct sockaddr_in) + 16)
+ || (rem_addr_len < sizeof(struct sockaddr_in) + 16))
+ {
+ SetLastError(WSAEINVAL);
+ return FALSE;
+ }
+
fd = get_sock_fd( listener, FILE_READ_DATA, NULL );
if (fd == -1)
{
diff --git a/dlls/ws2_32/tests/sock.c b/dlls/ws2_32/tests/sock.c
index c1d6956..343fd94 100644
--- a/dlls/ws2_32/tests/sock.c
+++ b/dlls/ws2_32/tests/sock.c
@@ -5348,12 +5348,22 @@ static void test_AcceptEx(void)
bret = pAcceptEx(listener, acceptor, buffer, 0, 0, sizeof(struct sockaddr_in) + 16,
&bytesReturned, &overlapped);
- todo_wine ok(bret == FALSE && WSAGetLastError() == WSAEINVAL, "AcceptEx on too small local address size "
+ ok(bret == FALSE && WSAGetLastError() == WSAEINVAL, "AcceptEx on too small local address size "
+ "returned %d + errno %d\n", bret, WSAGetLastError());
+
+ bret = pAcceptEx(listener, acceptor, buffer, 0, sizeof(struct sockaddr_in) + 15,
+ sizeof(struct sockaddr_in) + 16, &bytesReturned, &overlapped);
+ ok(bret == FALSE && WSAGetLastError() == WSAEINVAL, "AcceptEx on too small local address size "
"returned %d + errno %d\n", bret, WSAGetLastError());
bret = pAcceptEx(listener, acceptor, buffer, 0, sizeof(struct sockaddr_in) + 16, 0,
&bytesReturned, &overlapped);
- todo_wine ok(bret == FALSE && WSAGetLastError() == WSAEINVAL, "AcceptEx on too small remote address size "
+ ok(bret == FALSE && WSAGetLastError() == WSAEINVAL, "AcceptEx on too small remote address size "
+ "returned %d + errno %d\n", bret, WSAGetLastError());
+
+ bret = pAcceptEx(listener, acceptor, buffer, 0, sizeof(struct sockaddr_in) + 16,
+ sizeof(struct sockaddr_in) + 15, &bytesReturned, &overlapped);
+ ok(bret == FALSE && WSAGetLastError() == WSAEINVAL, "AcceptEx on too small remote address size "
"returned %d + errno %d\n", bret, WSAGetLastError());
bret = pAcceptEx(listener, acceptor, buffer, 0,
@@ -5362,6 +5372,10 @@ static void test_AcceptEx(void)
ok(bret == FALSE && WSAGetLastError() == ERROR_INVALID_PARAMETER, "AcceptEx on a NULL overlapped "
"returned %d + errno %d\n", bret, WSAGetLastError());
+ bret = pAcceptEx(listener, acceptor, buffer, 0, 0, 0, &bytesReturned, NULL);
+ ok(bret == FALSE && WSAGetLastError() == ERROR_INVALID_PARAMETER, "AcceptEx on a NULL overlapped "
+ "returned %d + errno %d\n", bret, WSAGetLastError());
+
bret = pAcceptEx(listener, acceptor, buffer, sizeof(buffer) - 2*(sizeof(struct sockaddr_in) + 16),
sizeof(struct sockaddr_in) + 16, sizeof(struct sockaddr_in) + 16,
&bytesReturned, &overlapped);
More information about the wine-cvs
mailing list