Nikolay Sivov : msxml3: Fixed attribute value string leak (Valgrind).
Alexandre Julliard
julliard at winehq.org
Mon Apr 28 13:27:00 CDT 2014
Module: wine
Branch: master
Commit: f9df8845361163c21c4ab8f126cf38813e52c857
URL: http://source.winehq.org/git/wine.git/?a=commit;h=f9df8845361163c21c4ab8f126cf38813e52c857
Author: Nikolay Sivov <nsivov at codeweavers.com>
Date: Sat Apr 26 00:36:24 2014 +0400
msxml3: Fixed attribute value string leak (Valgrind).
---
dlls/msxml3/element.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/dlls/msxml3/element.c b/dlls/msxml3/element.c
index 5e8822e..4fe53a8 100644
--- a/dlls/msxml3/element.c
+++ b/dlls/msxml3/element.c
@@ -1284,7 +1284,11 @@ static HRESULT WINAPI domelem_setAttribute(
xmlFree(local);
if (ns)
- return xmlStrEqual(ns->href, xml_value) ? S_OK : E_INVALIDARG;
+ {
+ int cmp = xmlStrEqual(ns->href, xml_value);
+ heap_free(xml_value);
+ return cmp ? S_OK : E_INVALIDARG;
+ }
}
if (!xmlSetNsProp(element, NULL, xml_name, xml_value))
More information about the wine-cvs
mailing list