Dmitry Timoshkov : taskschd: Implement ITaskService::get_Connected.

Alexandre Julliard julliard at winehq.org
Tue Jan 14 13:44:59 CST 2014


Module: wine
Branch: master
Commit: 189bfa96436774fc97c716c8b08999da04bb52cd
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=189bfa96436774fc97c716c8b08999da04bb52cd

Author: Dmitry Timoshkov <dmitry at baikal.ru>
Date:   Tue Jan 14 17:18:03 2014 +0900

taskschd: Implement ITaskService::get_Connected.

---

 dlls/taskschd/task.c            |   13 +++++++++++--
 dlls/taskschd/tests/scheduler.c |    4 ----
 2 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/dlls/taskschd/task.c b/dlls/taskschd/task.c
index 87d9273..76c0e9b 100644
--- a/dlls/taskschd/task.c
+++ b/dlls/taskschd/task.c
@@ -35,6 +35,7 @@ typedef struct
 {
     ITaskService ITaskService_iface;
     LONG ref;
+    BOOL connected;
 } TaskService;
 
 static inline TaskService *impl_from_ITaskService(ITaskService *iface)
@@ -135,8 +136,15 @@ static HRESULT WINAPI TaskService_Connect(ITaskService *iface, VARIANT server, V
 
 static HRESULT WINAPI TaskService_get_Connected(ITaskService *iface, VARIANT_BOOL *connected)
 {
-    FIXME("%p,%p: stub\n", iface, connected);
-    return E_NOTIMPL;
+    TaskService *task_svc = impl_from_ITaskService(iface);
+
+    TRACE("%p,%p\n", iface, connected);
+
+    if (!connected) return E_POINTER;
+
+    *connected = task_svc->connected ? VARIANT_TRUE : VARIANT_FALSE;
+
+    return S_OK;
 }
 
 static HRESULT WINAPI TaskService_get_TargetServer(ITaskService *iface, BSTR *server)
@@ -192,6 +200,7 @@ HRESULT TaskService_create(void **obj)
 
     task_svc->ITaskService_iface.lpVtbl = &TaskService_vtbl;
     task_svc->ref = 1;
+    task_svc->connected = FALSE;
     *obj = &task_svc->ITaskService_iface;
 
     TRACE("created %p\n", *obj);
diff --git a/dlls/taskschd/tests/scheduler.c b/dlls/taskschd/tests/scheduler.c
index 9b99258..adb7487 100644
--- a/dlls/taskschd/tests/scheduler.c
+++ b/dlls/taskschd/tests/scheduler.c
@@ -48,9 +48,7 @@ static void test_Connect(void)
 
     vbool = 0xdead;
     hr = ITaskService_get_Connected(service, &vbool);
-todo_wine
     ok(hr == S_OK, "get_Connected error %#x\n", hr);
-todo_wine
     ok(vbool == VARIANT_FALSE, "expected VARIANT_FALSE, got %d\n", vbool);
 
     hr = ITaskService_get_TargetServer(service, &bstr);
@@ -81,7 +79,6 @@ todo_wine
 
     vbool = 0xdead;
     hr = ITaskService_get_Connected(service, &vbool);
-todo_wine
     ok(hr == S_OK, "get_Connected error %#x\n", hr);
 todo_wine
     ok(vbool == VARIANT_TRUE, "expected VARIANT_TRUE, got %d\n", vbool);
@@ -92,7 +89,6 @@ todo_wine
 
     vbool = 0xdead;
     hr = ITaskService_get_Connected(service, &vbool);
-todo_wine
     ok(hr == S_OK, "get_Connected error %#x\n", hr);
 todo_wine
     ok(vbool == VARIANT_TRUE, "expected VARIANT_TRUE, got %d\n", vbool);




More information about the wine-cvs mailing list