Nikolay Sivov : msi: Fix a record leak on failure removing a column ( Coverity).
Alexandre Julliard
julliard at winehq.org
Thu Mar 27 14:40:05 CDT 2014
Module: wine
Branch: master
Commit: 195168351fe0aadc1e1a550a80e68c88f3832b12
URL: http://source.winehq.org/git/wine.git/?a=commit;h=195168351fe0aadc1e1a550a80e68c88f3832b12
Author: Nikolay Sivov <nsivov at codeweavers.com>
Date: Thu Mar 27 06:57:30 2014 +0400
msi: Fix a record leak on failure removing a column (Coverity).
---
dlls/msi/table.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/dlls/msi/table.c b/dlls/msi/table.c
index bd15a8e..8012369 100644
--- a/dlls/msi/table.c
+++ b/dlls/msi/table.c
@@ -1970,7 +1970,10 @@ static UINT TABLE_remove_column(struct tagMSIVIEW *view, LPCWSTR table, UINT num
r = TABLE_CreateView(tv->db, szColumns, &columns);
if (r != ERROR_SUCCESS)
+ {
+ msiobj_release(&rec->hdr);
return r;
+ }
r = msi_table_find_row((MSITABLEVIEW *)columns, rec, &row, NULL);
if (r != ERROR_SUCCESS)
More information about the wine-cvs
mailing list