Michael Stefaniuc : msxml3/tests: Actually test the return values ( PVS-Studio).

Alexandre Julliard julliard at wine.codeweavers.com
Mon Jan 19 16:00:05 CST 2015


Module: wine
Branch: master
Commit: 1caf6286f0b5a596b94f9406c5d83d82c2d23428
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=1caf6286f0b5a596b94f9406c5d83d82c2d23428

Author: Michael Stefaniuc <mstefani at redhat.de>
Date:   Mon Jan 19 12:58:11 2015 +0100

msxml3/tests: Actually test the return values (PVS-Studio).

---

 dlls/msxml3/tests/domdoc.c | 1 +
 dlls/msxml3/tests/schema.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c
index a23fb66..e669de4 100644
--- a/dlls/msxml3/tests/domdoc.c
+++ b/dlls/msxml3/tests/domdoc.c
@@ -11085,6 +11085,7 @@ static void test_xmlns_attribute(void)
     V_VT(&v) = VT_BSTR;
     V_BSTR(&v) = _bstr_("urn:schemas-microsoft-com:datatypes");
     hr = IXMLDOMAttribute_put_nodeValue(pAttribute, v);
+    ok(hr == S_OK, "ret %08x\n", hr );
 
     hr = IXMLDOMElement_setAttributeNode(root, pAttribute, NULL);
     ok(hr == S_OK, "ret %08x\n", hr );
diff --git a/dlls/msxml3/tests/schema.c b/dlls/msxml3/tests/schema.c
index f5d6fcd..be18fcf 100644
--- a/dlls/msxml3/tests/schema.c
+++ b/dlls/msxml3/tests/schema.c
@@ -1292,6 +1292,7 @@ static void test_XDR_datatypes(void)
 
         VariantClear(&type);
         hr = IXMLDOMNode_get_nodeTypedValue(node, &type);
+        EXPECT_HR(hr, S_OK);
         ok(V_VT(&type) == VT_BSTR, "got variant type %i\n", V_VT(&v));
         VariantClear(&type);
         IXMLDOMNode_Release(node);




More information about the wine-cvs mailing list