=?UTF-8?Q?Andr=C3=A9=20Hentschel=20?=: winepulse: Avoid 32-bit calculation with 64-bit result (Coverity).

Alexandre Julliard julliard at wine.codeweavers.com
Wed Nov 18 10:33:31 CST 2015


Module: wine
Branch: master
Commit: 005ff502524942671d4422de1bf437681bcc3395
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=005ff502524942671d4422de1bf437681bcc3395

Author: André Hentschel <nerv at dawncrow.de>
Date:   Mon Nov 16 22:36:00 2015 +0100

winepulse: Avoid 32-bit calculation with 64-bit result (Coverity).

Signed-off-by: André Hentschel <nerv at dawncrow.de>
Signed-off-by: Andrew Eikum <aeikum at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/winepulse.drv/mmdevdrv.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/dlls/winepulse.drv/mmdevdrv.c b/dlls/winepulse.drv/mmdevdrv.c
index b2f83c8..7369802 100644
--- a/dlls/winepulse.drv/mmdevdrv.c
+++ b/dlls/winepulse.drv/mmdevdrv.c
@@ -2239,10 +2239,9 @@ static HRESULT WINAPI AudioClock_GetFrequency(IAudioClock *iface, UINT64 *freq)
     pthread_mutex_lock(&pulse_lock);
     hr = pulse_stream_valid(This);
     if (SUCCEEDED(hr)) {
+        *freq = This->ss.rate;
         if (This->share == AUDCLNT_SHAREMODE_SHARED)
-            *freq = This->ss.rate * pa_frame_size(&This->ss);
-        else
-            *freq = This->ss.rate;
+            *freq *= pa_frame_size(&This->ss);
     }
     pthread_mutex_unlock(&pulse_lock);
     return hr;




More information about the wine-cvs mailing list