Nikolay Sivov : shell32: Remove recurring return value check (PVS-Studio).

Alexandre Julliard julliard at wine.codeweavers.com
Mon Oct 19 11:34:19 CDT 2015


Module: wine
Branch: master
Commit: e2275b0a2a584cfc871b93437e591ff9b8243e3a
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=e2275b0a2a584cfc871b93437e591ff9b8243e3a

Author: Nikolay Sivov <nsivov at codeweavers.com>
Date:   Mon Oct 19 00:29:28 2015 +0300

shell32: Remove recurring return value check (PVS-Studio).

Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/shell32/shellpath.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/dlls/shell32/shellpath.c b/dlls/shell32/shellpath.c
index 1a4528f..9440563 100644
--- a/dlls/shell32/shellpath.c
+++ b/dlls/shell32/shellpath.c
@@ -5568,8 +5568,7 @@ static HRESULT register_folder(const KNOWNFOLDERID *rfid, const KNOWNFOLDER_DEFI
 
     if(SUCCEEDED(hr))
     {
-        if(SUCCEEDED(hr))
-            hr = HRESULT_FROM_WIN32(RegSetValueExW(hKey, szCategory, 0, REG_DWORD, (LPBYTE)&pKFD->category, sizeof(pKFD->category)));
+        hr = HRESULT_FROM_WIN32(RegSetValueExW(hKey, szCategory, 0, REG_DWORD, (LPBYTE)&pKFD->category, sizeof(pKFD->category)));
 
         if(SUCCEEDED(hr) && pKFD->dwAttributes != 0)
             hr = HRESULT_FROM_WIN32(RegSetValueExW(hKey, szAttributes, 0, REG_DWORD, (LPBYTE)&pKFD->dwAttributes, sizeof(pKFD->dwAttributes)));




More information about the wine-cvs mailing list