Sven Baars : ntoskrnl.exe: Don' t use irp after it has been freed by IoCompleteRequest (Coverity).
Alexandre Julliard
julliard at winehq.org
Mon Aug 19 15:35:11 CDT 2019
Module: wine
Branch: master
Commit: aa10b49c57afcdce35b167e893ce27bec07fa159
URL: https://source.winehq.org/git/wine.git/?a=commit;h=aa10b49c57afcdce35b167e893ce27bec07fa159
Author: Sven Baars <sven.wine at gmail.com>
Date: Sun Aug 18 13:11:26 2019 +0200
ntoskrnl.exe: Don't use irp after it has been freed by IoCompleteRequest (Coverity).
Signed-off-by: Sven Baars <sven.wine at gmail.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
---
dlls/ntoskrnl.exe/pnp.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/dlls/ntoskrnl.exe/pnp.c b/dlls/ntoskrnl.exe/pnp.c
index 30865a0..03c4c40 100644
--- a/dlls/ntoskrnl.exe/pnp.c
+++ b/dlls/ntoskrnl.exe/pnp.c
@@ -725,6 +725,7 @@ static NTSTATUS WINAPI pnp_manager_device_pnp( DEVICE_OBJECT *device, IRP *irp )
{
IO_STACK_LOCATION *stack = IoGetCurrentIrpStackLocation( irp );
struct root_pnp_device *root_device = device->DeviceExtension;
+ NTSTATUS status;
TRACE("device %p, irp %p, minor function %#x.\n", device, irp, stack->MinorFunction);
@@ -783,8 +784,9 @@ static NTSTATUS WINAPI pnp_manager_device_pnp( DEVICE_OBJECT *device, IRP *irp )
FIXME("Unhandled PnP request %#x.\n", stack->MinorFunction);
}
+ status = irp->IoStatus.u.Status;
IoCompleteRequest( irp, IO_NO_INCREMENT );
- return irp->IoStatus.u.Status;
+ return status;
}
static NTSTATUS WINAPI pnp_manager_driver_entry( DRIVER_OBJECT *driver, UNICODE_STRING *keypath )
More information about the wine-cvs
mailing list