Jacek Caban : ntoskrnl.exe: Don' t keep reference to driver created file objects on client side.

Alexandre Julliard julliard at winehq.org
Fri May 3 15:46:18 CDT 2019


Module: wine
Branch: master
Commit: 7223f11d4ad9c078a15909b72270352b3f41c5bc
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=7223f11d4ad9c078a15909b72270352b3f41c5bc

Author: Jacek Caban <jacek at codeweavers.com>
Date:   Fri May  3 15:41:18 2019 +0200

ntoskrnl.exe: Don't keep reference to driver created file objects on client side.

Server keeps instead.

Signed-off-by: Jacek Caban <jacek at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/ntoskrnl.exe/ntoskrnl.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/dlls/ntoskrnl.exe/ntoskrnl.c b/dlls/ntoskrnl.exe/ntoskrnl.c
index bfc8d27..cf5cde9 100644
--- a/dlls/ntoskrnl.exe/ntoskrnl.c
+++ b/dlls/ntoskrnl.exe/ntoskrnl.c
@@ -551,7 +551,6 @@ static void *create_file_object( HANDLE handle )
 /* transfer result of IRP back to wineserver */
 static NTSTATUS WINAPI dispatch_irp_completion( DEVICE_OBJECT *device, IRP *irp, void *context )
 {
-    FILE_OBJECT *file = irp->Tail.Overlay.OriginalFileObject;
     HANDLE irp_handle = context;
     void *out_buff = irp->UserBuffer;
 
@@ -571,12 +570,6 @@ static NTSTATUS WINAPI dispatch_irp_completion( DEVICE_OBJECT *device, IRP *irp,
     }
     SERVER_END_REQ;
 
-    if (irp->Flags & IRP_CLOSE_OPERATION)
-    {
-        ObDereferenceObject( file );
-        irp->Tail.Overlay.OriginalFileObject = NULL;
-    }
-
     if (irp->UserBuffer != irp->AssociatedIrp.SystemBuffer)
     {
         HeapFree( GetProcessHeap(), 0, irp->UserBuffer );
@@ -618,7 +611,6 @@ static NTSTATUS dispatch_create( const irp_params_t *params, void *in_buff, ULON
 
     if (!(irp = IoAllocateIrp( device->StackSize, FALSE ))) return STATUS_NO_MEMORY;
 
-    ObReferenceObject( file );
     irpsp = IoGetNextIrpStackLocation( irp );
     irpsp->MajorFunction = IRP_MJ_CREATE;
     irpsp->FileObject = file;




More information about the wine-cvs mailing list