Francois Gouget : testbot/web: Fix Apache intermittently not finding CreatePatches().
Alexandre Julliard
julliard at winehq.org
Fri Apr 2 15:33:17 CDT 2021
Module: tools
Branch: master
Commit: 50ecc7020fc26c2117c3499c5e9256688ec7a933
URL: https://source.winehq.org/git/tools.git/?a=commit;h=50ecc7020fc26c2117c3499c5e9256688ec7a933
Author: Francois Gouget <fgouget at codeweavers.com>
Date: Thu Apr 1 15:52:34 2021 +0200
testbot/web: Fix Apache intermittently not finding CreatePatches().
If CreatePatches() is not refered to with its full name Apache (mod_perl
really) intermittently fails to find it and issues an error of the form:
Undefined subroutine &WineTestBot::Jobs::CreatePatches called at .../testbot/lib/ObjectModel/Item.pm line 275.
Strangely enough it never has trouble finding any of the other Create*()
functions.
Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>
---
testbot/lib/WineTestBot/Jobs.pm | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/testbot/lib/WineTestBot/Jobs.pm b/testbot/lib/WineTestBot/Jobs.pm
index 5dbc1a7..a5ae135 100644
--- a/testbot/lib/WineTestBot/Jobs.pm
+++ b/testbot/lib/WineTestBot/Jobs.pm
@@ -454,7 +454,10 @@ my @PropertyDescriptors = (
CreateBasicPropertyDescriptor("Remarks", "Remarks", !1, !1, "A", 128),
CreateBasicPropertyDescriptor("Submitted", "Submitted", !1, !1, "DT", 19),
CreateBasicPropertyDescriptor("Ended", "Ended", !1, !1, "DT", 19),
- CreateItemrefPropertyDescriptor("Patch", "Submitted from patch", !1, !1, \&CreatePatches, ["PatchId"]),
+ # Somehow mod_perl sometimes fails to find CreatePatches() if not given the
+ # fully qualified name, but never has any trouble with the other Create*()
+ # functions.
+ CreateItemrefPropertyDescriptor("Patch", "Submitted from patch", !1, !1, \&WineTestBot::Patches::CreatePatches, ["PatchId"]),
CreateDetailrefPropertyDescriptor("Steps", "Steps", !1, !1, \&CreateSteps),
);
SetDetailrefKeyPrefix("Job", @PropertyDescriptors);
More information about the wine-cvs
mailing list