Francois Gouget : wineusb.sys: Fix a potential buffer overflow in add_usb_device().

Alexandre Julliard julliard at winehq.org
Mon Aug 23 16:24:14 CDT 2021


Module: wine
Branch: master
Commit: 9fe40c9f58412f210c1eb453f87b9fa871403183
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=9fe40c9f58412f210c1eb453f87b9fa871403183

Author: Francois Gouget <fgouget at free.fr>
Date:   Sun Aug 22 18:19:35 2021 +0200

wineusb.sys: Fix a potential buffer overflow in add_usb_device().

name needs to be able to hold 15 characters plus an unsigned int,
potentially up to 10 characters even if it is unlikely, plus the
trailing nul character.

Signed-off-by: Francois Gouget <fgouget at free.fr>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/wineusb.sys/wineusb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/wineusb.sys/wineusb.c b/dlls/wineusb.sys/wineusb.c
index 441ed338f1e..085acf77e6f 100644
--- a/dlls/wineusb.sys/wineusb.c
+++ b/dlls/wineusb.sys/wineusb.c
@@ -94,7 +94,7 @@ static void add_usb_device(libusb_device *libusb_device)
     DEVICE_OBJECT *device_obj;
     UNICODE_STRING string;
     NTSTATUS status;
-    WCHAR name[20];
+    WCHAR name[26];
     int ret;
 
     libusb_get_device_descriptor(libusb_device, &device_desc);




More information about the wine-cvs mailing list