Gabriel Ivăncescu : mshtml: Fix out-of-bounds props access.

Alexandre Julliard julliard at winehq.org
Thu Sep 16 15:34:31 CDT 2021


Module: wine
Branch: master
Commit: 2868e9350a18aa5154cb7772c2f848bb5646bed2
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=2868e9350a18aa5154cb7772c2f848bb5646bed2

Author: Gabriel Ivăncescu <gabrielopcode at gmail.com>
Date:   Wed Sep 15 16:06:07 2021 +0300

mshtml: Fix out-of-bounds props access.

Signed-off-by: Gabriel Ivăncescu <gabrielopcode at gmail.com>
Signed-off-by: Jacek Caban <jacek at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/mshtml/dispex.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/mshtml/dispex.c b/dlls/mshtml/dispex.c
index c7588006295..64ead8f115c 100644
--- a/dlls/mshtml/dispex.c
+++ b/dlls/mshtml/dispex.c
@@ -1736,7 +1736,7 @@ static HRESULT WINAPI DispatchEx_DeleteMemberByDispID(IDispatchEx *iface, DISPID
         DWORD idx = id - DISPID_DYNPROP_0;
         dynamic_prop_t *prop;
 
-        if(!get_dynamic_data(This) || idx > This->dynamic_data->prop_cnt)
+        if(!get_dynamic_data(This) || idx >= This->dynamic_data->prop_cnt)
             return S_OK;
 
         prop = This->dynamic_data->props + idx;




More information about the wine-cvs mailing list