Francois Gouget : testbot/orm: Simplify CombineKey() and SplitKey() a bit.

Alexandre Julliard julliard at winehq.org
Mon Jun 6 15:05:09 CDT 2022


Module: tools
Branch: master
Commit: 71c7c8376cbb98272b9fed71b35b88cfcd82c141
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=71c7c8376cbb98272b9fed71b35b88cfcd82c141

Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Mon Jun  6 02:59:20 2022 +0200

testbot/orm: Simplify CombineKey() and SplitKey() a bit.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 testbot/lib/ObjectModel/Collection.pm | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/testbot/lib/ObjectModel/Collection.pm b/testbot/lib/ObjectModel/Collection.pm
index 63d470b..1a48eec 100644
--- a/testbot/lib/ObjectModel/Collection.pm
+++ b/testbot/lib/ObjectModel/Collection.pm
@@ -462,18 +462,14 @@ sub IsEmpty($)
 
 sub CombineKey($@)
 {
-  my $self = shift;
-
-  my $CombinedKey = join("#@#", @_);
-  return $CombinedKey;
+  my $_self = shift;
+  return join("#@#", @_);
 }
 
 sub SplitKey($$)
 {
-  my ($self, $CombinedKey) = @_;
-
-  my @KeyComponents = split /#@#/, $CombinedKey;
-  return @KeyComponents;
+  my ($_self, $CombinedKey) = @_;
+  return split /#@#/, $CombinedKey;
 }
 
 =pod




More information about the wine-cvs mailing list