SHLWAPI pre-submit questions

[Francois Gouget]

On Tue, 4 Dec 2001, Jon Griffiths wrote:

> Hi,
> 
> I've been hacking on SHLWAPI.dll for a couple of months now while
> holidaying around Thailand, using a beaten up laptop. Since I just
> obtained free use of a real machine with a good net connection, I
> want to start submitting my work but I thought I'd clear up a few
> style issues beforehand:
[...]
> 2. Is it OK to sync shlwapi.h with the windows version ?

   Yes, it's always a good idea to have the headers match more closely
their windows cousins.


> 3. How to deal with shared undocumented functions?
> 
> e.g. StrRetToBufA/W is used by shell32, but should not defined in
> shlwapi.h. 

   Actually it's no longer the case and there is a nice comment that
explains why (thanks Guy :-).

   Guy has been doing a lot of work on SHLWAPI lately. Since you have
been working on it while being disconnected from the net for so long (my
assumption since you were on holiday abroad, I may be wrong), it's
probably worth a good check to make sure there's no conflict with Guy's
work.


> Here there are 4 Choices:
> 1. Define twice (Ugly)
> 2. Put into a new wine/undocshlwapi.h (Seems that these are
> depreciated?)
> 3. Define anyway  (Im not a fan of having undoc functions in public
> headers)
> 4. Have shell32 functions #include "../shlwapi/internal.h" (A little
> unclean)

   If there are still undocumented functions that need to be shared,
then I would go for either 2 or 5:

  5. define the functions in shlwapi.h inside an '#ifdef __WINE__'.


--
Francois Gouget         fgouget at free.fr        http://fgouget.free.fr/
                  In a world without fences who needs Gates?