We *really* need a development model change !

[Andriy Palamarchuk]

--- Alexandre Julliard <julliard at winehq.com> wrote:
> The truth is that a lot of people are
> willing to setup a
> testing infrastructure, but nobody is willing to
> write the actual
> tests.

Counterexamples:
1) I suspect that you try to run the code you develop
before committing it to CVS ;-) You work on core Wine
functionality and the test code snippets you use would
be invaluable as unit tests. However I can't find
these tests anywhere in CVS tree :-P

2) Besides Perl testing framework there are a few
testing applications (vartest, guitest) in CVS, but
they are not merged in a single test suite.

3) I tried to submit unit test application for
SystemParametersInfo with my first patch to this
function, but the unit test was not accepted. I
assumed that no unit test is necessary in CVS tree for
such really simple function.

Summary - there are people who wants to develop unit
tests. IMO the problem with unit test in the project
is in:
1) Our attitude. We don't have *any* policy about unit
tests. Developers are not asked about unit tests, from
the documents on WineHQ it is not clear whether we
need them at all. 

2) Absense of infrastracture. We need to develop or
choose unit testing framework, define unit test
policies, add information about unit tests to Wine
documentation, keep unit tests visible for developers
all the time.

> So right now we have a minimal infrastructure in
> Perl

No, ability to call W32 API functions is not
considered a unit test infrastracture. I may say Wine
has such infrastructure for C since 1993 :-). From
this point of view Andreas test application provides
more support for unit tests than plain Perl module.

In existing CVS tree we have much more tests in C than
in Perl (both - a little more than nothing)

> I'm not
> going to setup another one until someone starts
> using the existing one
> seriously and demonstrates whether it works or not
> in practice. The
> theory has been discussed to death already.

I agree with you - only usage of the framework can
help to choose better one. I'll look more closely at
C-based, try to combine our Perl module with
Perl-based unit frameworks.


Andriy Palamarchuk

__________________________________________________
Do You Yahoo!?
Send your FREE holiday greetings online!
http://greetings.yahoo.com