Win16 problems

Gerard Patel gerard.patel at nerim.net
Sat Jul 7 18:52:22 CDT 2001


At 10:43 PM 03/07/2001 +0200, you wrote:
<snip>
>winmine fails to draw, whereas freecell runs just fine

Yes, I see the problem with winmine; but is it really a 16-bits
problem ?

What I see is an app creating its main window iconic (minimized), then
showing it using ShowWindow.

Current Wine code does not take this particular behaviour (completely
absurd, granted) in account - When the window is created the 'client'
window is not mapped (since it's iconic, nothing surprising here), but
in ShowWindow the iconic flag (WS_MINIMIZED) is cleared, and when
SetWindowPos is called by ShowWindow, 
X11DRV_sync_client_window_position cleverly detects that the window
is already mapped ;-) and decides that it's not necessary to do anything
more.

This seems more a Winmine specific problem than otherwise.
BTW, I can't see any problem with sol.exe (win3.11 version)

This patch :

--- window.c.orig       Wed Jun 27 03:03:36 2001
+++ window.c    Sat Jul  7 23:19:03 2001
@@ -596,7 +596,7 @@
         if (was_mapped && !is_client_window_mapped( win ))
             XUnmapWindow( display, data->client_window );
         XConfigureWindow( display, data->client_window, mask, &changes );
-        if (!was_mapped && is_client_window_mapped( win ))
+        if (is_client_window_mapped( win ))
             XMapWindow( display, data->client_window );
         wine_tsx11_unlock();
     }


works around this particular problem.

Gerard








More information about the wine-devel mailing list