minor regression testing patch

Paul Millar paulm at astro.gla.ac.uk
Sun Apr 21 13:29:46 CDT 2002


Hi,

Found attached bug. Curiously, the test doesn't fail even if wine is
pretending to be Windows 95 :)

ChangeLog:
  Fixed typo "Major" -> "Minor"


BTW,
After the patch, the test for WIN98 or later is:

#define WIN98_PLUS(version) (version.dwMajorVersion==4 && \
                             version.dwMinorVersion>0)

but, MS's documentation:
  http://msdn.microsoft.com/library/en-us/sysinfo/sysinfo_49iw.asp
suggests something more like:

#define WIN98_PLUS(version) \
  ( (version.dwPlatformId == VER_PLATFORM_WIN32_WINDOWS) && \
    ( (version.dwMajorVersion > 4) || \
      (version.dwMajorVersion==4 && version.dwMinorVersion>0)))

Is this more correct?

----
Paul Millar
-------------- next part --------------
Index: dlls/kernel/tests/path.c
===================================================================
RCS file: /home/wine/wine/dlls/kernel/tests/path.c,v
retrieving revision 1.1
diff -u -r1.1 path.c
--- dlls/kernel/tests/path.c	11 Apr 2002 21:49:23 -0000	1.1
+++ dlls/kernel/tests/path.c	21 Apr 2002 18:01:37 -0000
@@ -26,7 +26,7 @@
 
 #define WIN2K_PLUS(version) (version.dwMajorVersion==5)
 #define WIN98_PLUS(version) (version.dwMajorVersion==4 && \
-                             version.dwMajorVersion>0)
+                             version.dwMinorVersion>0)
 #define HAS_TRAIL_SLASH_A(string) (string[lstrlenA(string)-1]=='\\')
 
 #define LONGFILE "Long File test.path"


More information about the wine-devel mailing list