wine/ dlls/winsock/socket.c dlls/winsock/ws2_3 ...

Martin Wilck Martin.Wilck at fujitsu-siemens.com
Fri Apr 26 05:22:42 CDT 2002


Alexandre,

-static int FILE_GetUnixHandleType( HANDLE handle, DWORD access, enum
fd_type *type, int *flags )
+static int FILE_GetUnixHandleType( HANDLE handle, DWORD access, enum
fd_type *type, int *flags_ptr )
 {
-    int ret, fd = -1;
+    int ret, flags, fd = -1;

-    ret = wine_server_handle_to_fd( handle, access, &fd, type, flags );
+    ret = wine_server_handle_to_fd( handle, access, &fd, type, &flags );
+    if (flags_ptr) *flags_ptr = flags;

This is of course the most robust solution - but because
FILE_GetUnixHandleType is internal, you might as well require all
functions calling it to pass a valid flags pointer, and let
FILE_GetUnixHandle call wine_server_handle_to_fd directly, at a minimum
performance gain.

Martin

-- 
Martin Wilck                Phone: +49 5251 8 15113
Fujitsu Siemens Computers   Fax:   +49 5251 8 20409
Heinz-Nixdorf-Ring 1	    mailto:Martin.Wilck at Fujitsu-Siemens.com
D-33106 Paderborn           http://www.fujitsu-siemens.com/primergy








More information about the wine-devel mailing list