WIN_Handle{16,32} questions

[Alexandre Julliard]

Michael Stefaniuc <mstefani at redhat.de> writes:

> Assuming that WIN_Handle{16,32} are not windows funtions (a search on
> google has given only links to wine pages) i would do following:
> - rename WIN_Handle{16,32} to HWND_{16,32} to make the naming consistent
>   to the othe handle conversions
> - maybe remove the declaration of the two functions from include/win.h
>   (or at least don't include win.h where it isn't yet used)
> - define HWND_16 as macro like the other HANDLE_16 macros and put it
>   directly in the files where it's needed

The macros should stay in win.h, you must not define them in every
single C file. For other dlls, you need to define them in some
appropriate internal header of the dll. There shouldn't be more than
one definition of the macros for each dll.

> - HWND_32 has to do a little bit more work then the other HANDLE_32
>   macros and i would keep it as function. This means it has to be
>   duplicated in every dll that needs it and one of the *16.c files in
>   the dll directory would be the place to put it in.

Other dlls should probably do a simple 16->32 conversion like for
other handles; you definitely don't want to duplicate WIN_Handle32 in
the other dlls.

-- 
Alexandre Julliard
julliard at winehq.com