Patch: BUG in thread_queue_apc()

Martin Wilck Martin.Wilck at fujitsu-siemens.com
Tue Jan 8 09:24:56 CST 2002


The patch below fixes a bug in server/thread.c that causes
APCs to be "forgotten".

The patch is against today's CVS (2002-01-08).

I came across this by testing async file I/O. When submitting several
async IO requests, the IO completion routine was called only once for
the first submitted request.

I cannot oversee if this can break anything elsewhere, but I strongly
believe the behaviour with this patch is more sane than without.

Martin

-- 
Martin Wilck                Phone: +49 5251 8 15113
Fujitsu Siemens Computers   Fax:   +49 5251 8 20409
Heinz-Nixdorf-Ring 1	    mailto:Martin.Wilck at Fujitsu-Siemens.com
D-33106 Paderborn           http://www.fujitsu-siemens.com/primergy

Index: server/thread.c
===================================================================
RCS file: /home/wine/wine/server/thread.c,v
retrieving revision 1.72
diff -u -r1.72 thread.c
--- server/thread.c	2001/12/20 00:07:09	1.72
+++ server/thread.c	2002/01/08 13:35:17
@@ -562,6 +562,8 @@
         queue->head = apc;
         wake_thread( thread );
     }
+    else apc->prev->next = apc;
+
     return 1;
 }







More information about the wine-devel mailing list