ReactOS/Mingw32 port

[Alexandre Julliard]

"Steven Edwards" <Steven_Ed4153 at yahoo.com> writes:

> 1. Makefiles and Resources
> Alexandre: I know you said you might not accept our makefiles but I went
> ahead and sent them for your review, if you don’t want to apply them no
> problem. Will you accept the .def's for the dlls as we cannot use the
> .specs? No big deal if not because we can keep them on our CVS. Also due
> to a bug in windress we cannot use the wine resources so we have to use
> binary resources for our port. Will you accept those? If not, once again
> no big deal we can keep the makefiles, resources and defs in our CVS
> tree.

I don't think any of these belong in Wine CVS. For Makefiles the best
solution would be to fix whatever is needed in the Wine makefiles to
make them work for you.

.def files could either be generated from the .spec file, or winebuild
could be modified to work with .def files. But in any case we should
not have to maintain the same information at two different places.

Binary resources obviously shouldn't be put into the tree; why can't
you build them from source under ReactOS?  Can't you use Wine wrc for
that?

> 3. Everything else
> I'm still new to the whole programming thing so I'm open for suggestions
> from everyone. If anyone has a better way of doing the port rather then
> #ifdef/#endif let me know. 

You should be using configure if possible. If you use #ifdefs you have
to test features detected by configure (the HAVE_xxx symbols); as a
rule platform-specific #ifdefs (like #ifdef REACTOS) must be avoided.
But all kinds of ifdefs should be avoided as much as possible.

-- 
Alexandre Julliard
julliard at winehq.com