shlwapi shreg tests failed

[Paul Millar]

On Wed, 22 May 2002, [iso-8859-1] Sylvain Petreolle wrote:
> > Sorry for the delay in replying ..
> No problem. Time is gold.

True :)


> >   What happens for other Window versions (e.g. win95
> > and win2k)?
> Not tested for the moment.
> I only tested without options (fails) and with an
> alias
> to wine : alias wine='wine --winver=winme'.
> That solves some issues due to child process version
> misleading.

Ah!

I think this might be the culprit. The runtest program builds the (unix)
command up from various pieces. It will exec wine via its absolute path,
but takes no account of any shell aliases -- or at least it didn't for me.

To check, try adding the simple attached patch, and rerun the tests. If
don't see any "*** forcing wine version to be winme" lines, then wine will
default to some kind of lowest common denominator, depending on what DLLs
are linked.

On my machine/configuration, that's win95.

Cheers,

----
Paul Millar
-------------- next part --------------
Index: misc/version.c
===================================================================
RCS file: /home/wine/wine/misc/version.c,v
retrieving revision 1.51
diff -u -r1.51 version.c
--- misc/version.c	9 May 2002 19:36:28 -0000	1.51
+++ misc/version.c	23 May 2002 10:06:51 -0000
@@ -213,6 +213,7 @@
             {
                 defaultWinVersion = (WINDOWS_VERSION)i;
                 versionForced = TRUE;
+                MESSAGE("*** forcing wine version to be %s.\n", WinVersionNames[i]); 
                 return;
             }
             pCurr = p+1;
@@ -408,11 +409,16 @@
     {
         WINDOWS_VERSION retver;
 	  
-        if (versionForced) /* user has overridden any sensible checks */
+        if (versionForced) {
+              /* user has overridden any sensible checks */
 	    winver = defaultWinVersion;
+            MESSAGE("*** wine forced as %s\n", WinVersionNames[winver]);
+        }
 	else
 	{
 	    retver = VERSION_GetLinkedDllVersion();
+
+            MESSAGE("*** after looking at linked DLLs, wine trying to be %s.\n", WinVersionNames[retver]); 
 
 	    /* cache determined value, but do not store in case of WIN31 */
 	    if (retver != WIN31) winver = retver;