winsock + DSTRICT

Michael Stefaniuc mstefani at redhat.de
Mon Oct 28 15:51:54 CST 2002


Hello Martin,

On Mon, Oct 28, 2002 at 04:07:46PM +0100, Martin Wilck wrote:
> here is a patch to make winsock compile without warnings without 
> -DWINE_NO_STRICT. Comments are welcome.
Well, i looked at the patch and it seems resonable. You are the winsock
expert and if you feel confortable with it please submit it to
wine-patches (Alexandre will complain if he dosn't like it ;). One
request: i'm not sure if the compiler will optimize away the assert
from __handle2socket on machines where sizeof(HANDLE) == sizeof(SOCKET).
But if not could you please add something like
if (sizeof(HANDLE) > sizeof(SOCKET)) {
    assert(....
}
On i386 the size are equal and the assert not needed.


bye
	michael
-- 
Michael Stefaniuc               Tel.: +49-711-96437-199
System Administration           Fax.: +49-711-96437-111
Red Hat GmbH                    Email: mstefani at redhat.com
Hauptstaetterstr. 58            http://www.redhat.de/
D-70178 Stuttgart
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 232 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20021028/e3041824/attachment.pgp


More information about the wine-devel mailing list