winedbg: enhancing symbol lookup

[Alexandre Julliard]

Eric Pouech <eric.pouech at wanadoo.fr> writes:

> --- debugger/break.c	30 Jul 2002 00:06:34 -0000	1.35
> +++ debugger/break.c	2 Sep 2002 19:39:59 -0000
> @@ -421,10 +421,15 @@
>      DBG_VALUE 	value;
>      int		i;
>  
> -    if (DEBUG_GetSymbolValue(name, lineno, &value, TRUE))
> +    switch (DEBUG_GetSymbolValue(name, lineno, &value, TRUE))
>      {
> +    case TRUE:
>          DEBUG_AddBreakpoint(&value, NULL, TRUE);
>          return;
> +    case FALSE:
> +        break;
> +    case ABORT: /* user aborted symbol lookup */
> +        return;
>      }

Please don't invent a third boolean state. A boolean is either TRUE or
FALSE; if you need more than that you should define a new enum type
with meaningful names. Reusing TRUE and FALSE will cause major
confusion.

-- 
Alexandre Julliard
julliard at winehq.com